[PATCH] D83912: [llvm-readobj] Update tests because of changes at llvm-readobj behavior

Elvina Yakubova via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 03:03:11 PDT 2020


Elvina added a comment.

In D83912#2161524 <https://reviews.llvm.org/D83912#2161524>, @jhenderson wrote:

> Hi @Elvina,
>
> Just to let you know that I had to fix up three clang tests that were using the old behaviour too, prior to committing. I also noticed that you've got the stack the wrong way around - you needed to fix the tests before changing the behaviour in this case to avoid breaking the codebase, even if it was only briefly.
>
> Anyway, these are now committed. I'll update the bug.


Hi James,
Thank you for your help and suggestions! I really appreciate this. I'll be more attentive next time :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83912/new/

https://reviews.llvm.org/D83912





More information about the llvm-commits mailing list