[PATCH] D84419: Fix interaction between stack alignment and inline-asm stack clash protection

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 04:16:35 PDT 2020


lkail added inline comments.


================
Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:672
 
+  if (Align) {
+    const unsigned ADDOpc = getADDriOpcode(Uses64BitFramePtr, Align);
----------------
When `Align > StackProbeSize`, which should be rare, is there any chance that the first probe is performed on the old frame?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84419/new/

https://reviews.llvm.org/D84419





More information about the llvm-commits mailing list