[PATCH] D84493: [InstCombine] Disable branch predicate canonicalization

Yevgeny Rouban via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 04:14:26 PDT 2020


yrouban added a comment.

In D84493#2171571 <https://reviews.llvm.org/D84493#2171571>, @lebedev.ri wrote:

>


Thank you for pointing this out. I will try changing canonicalizeICmpPredicate(), canFreelyInvertAllUsersOf().

In D84493#2171571 <https://reviews.llvm.org/D84493#2171571>, @lebedev.ri wrote:

> Was the other proper solution of either updating PDT, or making it order-insensitive explored and turned out to be impossible?


Nobody proposed a good solution with a PDT calculation fix to make it insensitive to the branch order. PDT could not be updated properly either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84493/new/

https://reviews.llvm.org/D84493





More information about the llvm-commits mailing list