[PATCH] D84398: [yaml2obj] - Introduce a way to set default values when using ShOffset, ShName and ShSize fields.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 03:03:19 PDT 2020


grimar abandoned this revision.
grimar added a comment.

In D84398#2169466 <https://reviews.llvm.org/D84398#2169466>, @jhenderson wrote:

> To be clear, is the intent here is to allow yaml2obj to produce two different outputs form the same input where the only difference is that one provides a custom value and the other doesn't?


Right.

> How about a slightly more general concept: have a "None" special value (or "NONE" etc), parallel to llvm::Optional, which is equivalent to not specifying the field at all.

I like the idea too. I've prototyped a patch, it looks fine, I think, now I am working on tests, hope to post it soon.
(I've used `<none>` as a special value, btw. I think it has less chance to conflict with `None`/`none`. I've avoided using `NONE` because it looks like a macro, though I'd slightly
prefer to use `NONE` rather than `None` if we deside that `<none>` doesn't work for whatever reason).

I am abandoning this revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84398/new/

https://reviews.llvm.org/D84398





More information about the llvm-commits mailing list