[PATCH] D84181: [GVN] Rewrite IsValueFullyAvailableInBlock()

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 02:49:25 PDT 2020


lebedev.ri added inline comments.


================
Comment at: llvm/test/Transforms/GVN/loadpre-missed-opportunity.ll:7
 
 declare void @use(i32*)
 
----------------
fhahn wrote:
> Not used currently? I think the test below would benefit from having some actual users of `%i` & `i7` that cannot be folded away.
It would benefit indeed, but that breaks the test :/
It's overreduced, but i'm not sure what extra interestingness tests i should have used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84181/new/

https://reviews.llvm.org/D84181





More information about the llvm-commits mailing list