[PATCH] D83592: [Coverage] Add comment to skipped regions

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 24 02:04:29 PDT 2020


hans added inline comments.


================
Comment at: clang/lib/Lex/Preprocessor.cpp:973
+  if ((LexLevel == 0 || PreprocessToken) &&
+      !Result.getFlag(Token::IsReinjected)) {
+    if (LexLevel == 0)
----------------
zequanwu wrote:
> @hans , can you take a look on this part? I saw `TokenCount` was introduced for a warning `-Wmax-tokens`.
Can you explain why things are changing here?

The idea of TokenCount is to simply count the preprocessor tokens. At this point I think you have more knowledge here than I did when I added it :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83592/new/

https://reviews.llvm.org/D83592





More information about the llvm-commits mailing list