[PATCH] D84181: [GVN] Rewrite IsValueFullyAvailableInBlock()

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/GVN/loadpre-missed-opportunity.ll:4
 
 target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
----------------
those should not be needed.


================
Comment at: llvm/test/Transforms/GVN/loadpre-missed-opportunity.ll:7
 
 declare void @use(i32*)
 
----------------
Not used currently? I think the test below would benefit from having some actual users of `%i` & `i7` that cannot be folded away.


================
Comment at: llvm/test/Transforms/GVN/loadpre-missed-opportunity.ll:66
 
 declare dso_local i32* @zzz() local_unnamed_addr
----------------
nit: unnecessary attribute/dso_local. Same for _Z2axv


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84181/new/

https://reviews.llvm.org/D84181