[PATCH] D84054: [lld][ELF] Add LOG2CEIL builtin ldscript function

Fri Jul 24 01:24:21 PDT 2020

grimar added a comment.

In D84054#2169708 <https://reviews.llvm.org/D84054#2169708>, @irichter wrote:

> I could test every transition (e.g. 0x0f, 0x10, 0x1f, 0x20, 0x3f, 0x40, ...), but that'll be >100 tests. I took a quick look at the libc and libcxx tests for log2, but those seem much more detailed than I'd expect to find in lld.
>
> What do you think would be sufficient?

I do not think we should focus too much on this in LLD test. I think just a few values should be fine. E.g 0, 1, 2, 3, 4, 65535, 65536, uint64(-1)
@maskray, what do you think?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84054/new/

https://reviews.llvm.org/D84054