[PATCH] D83834: Add test utility 'extract'

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D83834#2171208 <https://reviews.llvm.org/D83834#2171208>, @dblaikie wrote:

> In D83834#2171199 <https://reviews.llvm.org/D83834#2171199>, @MaskRay wrote:
>
> > Use %extract only in `not %extract`
>
>
> So does 'extract' not work the same as all other tools in LLVM? It doesn't get substituted in non-starting locations?
>
> That inconsistency seems undesirable/best avoided. The xray collission is problematic, to be sure - might indicate that another name should be used, or perhaps some escaping to disable substitution would be useful (quotation marks seem like a fairly accessible/simple syntax to disable substitution, for instance)


llvm/test/lit.cfg.py

  # FIXME: Why do we have both `lli` and `%lli` that do slightly different things?
  tools.extend([
      'dsymutil', 'lli', 'lli-child-target', 'llvm-ar', 'llvm-as',
      'llvm-addr2line', 'llvm-bcanalyzer', 'llvm-config', 'llvm-cov',
      'llvm-cxxdump', 'llvm-cvtres', 'llvm-diff', 'llvm-dis', 'llvm-dwarfdump',
      'llvm-exegesis', 'llvm-extract', 'llvm-isel-fuzzer', 'llvm-ifs',
      'llvm-install-name-tool', 'llvm-jitlink', 'llvm-opt-fuzzer', 'llvm-lib',
      'llvm-link', 'llvm-lto', 'llvm-lto2', 'llvm-mc', 'llvm-mca',
      'llvm-modextract', 'llvm-nm', 'llvm-objcopy', 'llvm-objdump',
      'llvm-pdbutil', 'llvm-profdata', 'llvm-ranlib', 'llvm-rc', 'llvm-readelf',
      'llvm-readobj', 'llvm-rtdyld', 'llvm-size', 'llvm-split', 'llvm-strings',
      'llvm-strip', 'llvm-tblgen', 'llvm-undname', 'llvm-c-test', 'llvm-cxxfilt',
      'llvm-xray', 'yaml2obj', 'obj2yaml', 'yaml-bench', 'verify-uselistorder',
      'bugpoint', 'llc', 'llvm-symbolizer', 'opt', 'sancov', 'sanstats'])

Any tool in this list is special. They can be substituted in any position on a RUN line, either a 'command' position or an 'argument' position. I hope that we can deprecated this behavior.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834