[PATCH] D83669: [PowerPC] Support for R_PPC64_REL24_NOTOC calls where the caller has no TOC and the callee is not DSO local

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp accepted this revision as: stefanp.
stefanp added a comment.
This revision is now accepted and ready to land.

I only had one nit.
LGTM.



================
Comment at: lld/ELF/Thunks.cpp:911
+void PPC64PCRelPLTStub::addSymbols(ThunkSection &isec) {
+  addSymbol(saver.save("__plt_pc-rel_" + destination.getName()), STT_FUNC, 0,
+            isec);
----------------
nit:
Try to use `__plt_pcrel_` instead of `__plt_pc-rel_`. 
The `-` is probably fine as part of a function name but since I'm not 100% sure I would not risk it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83669/new/

https://reviews.llvm.org/D83669