[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

Yep, cool.
LGTM from me, but please get another pair if eyes (Vitaly?)



================
Comment at: clang/docs/DataFlowSanitizer.rst:182
+less CPU and code size overhead.  To use fast16labels instrumentation, you'll
+need to specify `-fsanitize=dataflow -mllvm -fast-16-labels` in your compile and
+link commands and use a modified API for creating and managing labels.
----------------
maybe -dataflow-fast-16-labels?


================
Comment at: clang/docs/DataFlowSanitizer.rst:201
+  int main(void) {
+    int i = 1;
+    int j = 2;
----------------
perhaps unconfuse the test a bit by using other constants 
  i = 100;
  j = 200;
  k = 300;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84371/new/

https://reviews.llvm.org/D84371