[PATCH] D84215: [DFSan] Handle fast16labels for all API functions.

Matt Morehouse via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 16:36:12 PDT 2020


FTR:  I reverted and relanded this patch without the Die() in
dfsan_dump_labels.  It was causing undefined behavior since
dfsan_dump_labels is called from an atexit() handler.  Seems to be passing
on the bots now.

On Thu, Jul 23, 2020 at 8:43 AM Matt Morehouse <mascasa at google.com> wrote:

> Thanks for the heads up, Yvan.  Looking into it...
>
> On Thu, Jul 23, 2020 at 4:00 AM Yvan Roux <yvan.roux at linaro.org> wrote:
>
>> Hi Matt,
>>
>> this commit broke AArch64 bots, logs are available here:
>>
>>
>> http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/10751/steps/ninja%20check%202/logs/FAIL%3A%20DataFlowSanitizer-aarch64%3A%3A%20fast16labels.c
>>
>> Cheers,
>> Yvan
>>
>> On Thu, 23 Jul 2020 at 01:55, Matt Morehouse via Phabricator via
>> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>>> This revision was automatically updated to reflect the committed changes.
>>> Closed by commit rG19d9c0397e61: [DFSan] Handle fast16labels for all API
>>> functions. (authored by morehouse).
>>>
>>> Repository:
>>>   rG LLVM Github Monorepo
>>>
>>> CHANGES SINCE LAST ACTION
>>>   https://reviews.llvm.org/D84215/new/
>>>
>>> https://reviews.llvm.org/D84215
>>>
>>> Files:
>>>   compiler-rt/lib/dfsan/dfsan.cpp
>>>   compiler-rt/test/dfsan/fast16labels.c
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200723/370b0eb8/attachment.html>


More information about the llvm-commits mailing list