[PATCH] D62884: [lld] Explicitly ignore comdat groups when parsing LTO object

Thu Jul 23 16:25:50 PDT 2020

dblaikie added a comment.

In D62884#2045111 <https://reviews.llvm.org/D62884#2045111>, @MaskRay wrote:

> In D62884#2044673 <https://reviews.llvm.org/D62884#2044673>, @christylee wrote:
>
> > We are trying to migrate from gold to lld, and we found that when building with thinlto, lld does not de-duplicate `.debug_types`.  De-duplication is successful with monolithic lto.  Repro: clang `-flto=thin -fdebug-types-section -fuse-ld=lld -Wl,-plugin-opt=-generate-type-units`
> >
> > If we set `ignoreComdats=false` for lto builds, then the de-duplication is successful again.  Is the assumption "any symbols defined in the LTO object are by definition the ones we want in the final output" only true for monolithic lto?
>
>
> + at dblaikie

Hey, sorry I missed this - picking up the conversation over at https://reviews.llvm.org/D80765#2170820 I think.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62884/new/

https://reviews.llvm.org/D62884