[PATCH] D84459: [llvm][NFC] Don't use llvm/Config/config.h in .h files

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 16:05:46 PDT 2020


thakis added inline comments.


================
Comment at: llvm/include/llvm/Analysis/InlineAdvisor.h:216
                           std::function<bool(CallBase &)> GetDefaultAdvice);
-#endif
 
----------------
thakis wrote:
> Hm, maybe it's better to move the other define to llvm-config and make these APIs available only if the config header advertises their existence? It seems a bit nicer for external clients if they can check at build time instead of at runtime maybe.
(Also, then no other change in this patch would be needed other than replacing some #include lines)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84459/new/

https://reviews.llvm.org/D84459





More information about the llvm-commits mailing list