[PATCH] D84463: [LegalizeTypes] Teach DAGTypeLegalizer::GenWidenVectorLoads to pad with undef if needed when concatenating small or loads to match a larger load

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 15:11:40 PDT 2020


efriedma added a comment.

> On almost all targets, if N is small, reading N bytes from a dereferenceable pointer with align N is safe, even if the known dereferenceable bytes is less than N, due to the way memory allocation works. We do this in a few places, I think?

Err, I guess you know that.  Yes, it's depending on the alignment here.

It might be a good idea to explicitly call this out on the line where we compute LdAlign.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84463/new/

https://reviews.llvm.org/D84463





More information about the llvm-commits mailing list