[PATCH] D84391: [AMDGPU] Fix incorrect arch assert while setting up FlatScratchInit

[Scott Linder via Phabricator via llvm-commits]

scott.linder added a comment.

Can we just add a predicate for whatever necessitates the SETREG for gfx10+? No idea on a good name, but if it were `flatScratchIsHwreg()` and it implied `flatScratchIsPointer()` this becomes:

  if (ST.flatScratchIsHwreg()) {
    // pointer add then S_SETREG
  } else if (ST.flatScratchIsPointer()) (
    // pointer add
  } else {
    // size and offset dance
  }
  llvm_unreachable();

I agree that the existing assert here doesn't really mean anything, not sure why I wrote it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84391/new/

https://reviews.llvm.org/D84391