[PATCH] D84354: [AMDGPU/MemOpsCluster] Clean-up fixme's around mem ops clustering logic
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 23 13:18:28 PDT 2020
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Test changes don't seem obviously worse
================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:477
unsigned NumBytes) const {
+ // If the mem ops in the current pair, do not have the same base ptr, then
+ // they cannot be clustered
----------------
arsenm wrote:
> Reads badly with the first comma
s/cannot/should not/, this isn't mandatory
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84354/new/
https://reviews.llvm.org/D84354
More information about the llvm-commits
mailing list