[PATCH] D84233: [lit] Escape ANSI control character in xunit output

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 11:43:37 PDT 2020


yln added a subscriber: jdenny.
yln added a comment.

@arichardson: can you double-check that this workaround is still needed?
Do we understand the semantics of CDATA blocks?  I was under the impression we use it here to avoid problems like this.

Anyways, I am fine with this.  Adding Joel as a second reviewer to get his feedback before accepting.

@jdenny:
Do you have opinions on this?  Is llvm-lit responsible for this (or should the fix be in Jenkins/Jenkin's config)?
Any other reviewers we should include?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84233/new/

https://reviews.llvm.org/D84233





More information about the llvm-commits mailing list