[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

George Rokos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 11:37:56 PDT 2020


grokos added a comment.

What confuses me about this interpretation of the standard is the inconsistency at `data exit`. So if we have an explicit `omp target exit data map(present...)` then we should respect the "present" semantics, whereas when we have a scoped data exit:

  #pragma omp target data map(present,...)
  {
    ...
  } // implicit "exit data" here

then "present" should be ignored.

I agree that the paragraph from the standard leaves little room for other interpretations, I'd just like to point out that it looks inconsistent - at least to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84422/new/

https://reviews.llvm.org/D84422





More information about the llvm-commits mailing list