[PATCH] D84447: [IPConstProp] Replace and move tests to SCCP.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 11:10:45 PDT 2020


jdoerfert added a comment.

In D84447#2170176 <https://reviews.llvm.org/D84447#2170176>, @nikic wrote:

> It looks like a lot of the tests here are about `!callback` support.


Yes. Pre-Attributor callbacks were only supported by this pass. These tests are subsumed by the Attributor test and Attributor interprets `!callback`. That said, removing those tests for SCCP is fine with me. Keeping them as "negative" test is as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84447/new/

https://reviews.llvm.org/D84447





More information about the llvm-commits mailing list