[PATCH] D84209: [llvm-libtool-darwin] Add support for -D option

Thu Jul 23 08:20:02 PDT 2020

sameerarora101 added a comment.

In D84209#2168725 <https://reviews.llvm.org/D84209#2168725>, @jhenderson wrote:

> In D84209#2167919 <https://reviews.llvm.org/D84209#2167919>, @sameerarora101 wrote:
>
> > It seems like cctools' `libtool` does not have an explicit flag for indicating non-deterministic behavior. Thus, if I set `Deterministic` to `true` by default, I would need to implement another flag (something like `-U`) to specify non-deterministic behavior for `llvm-libtool`. This would then be a slight deviation from libtool's behavior. What do you guys think?
>
>
> I think if we have `Deterministic` set to a different default value to libtool, we should definitely provide a `-U` option to allow a fallback, in case there are people who need that behaviour.

I see. Would we still need the `-D` option in that case?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84209/new/

https://reviews.llvm.org/D84209