[PATCH] D83462: [DWARF] Avoid entry_values production for SCE

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:429
   // the debug entry values feature. It can also be enabled explicitly.
-  EmitDebugEntryValues = (Asm->TM.Options.ShouldEmitDebugEntryValues() &&
-                          (tuneForGDB() || tuneForLLDB())) ||
-                         EmitDwarfDebugEntryValues;
+  EmitDebugEntryValues = Asm->TM.Options.ShouldEmitDebugEntryValues();
 
----------------
djtodoro wrote:
> aprantl wrote:
> > Wouldn't we want `(tuneForGDB() || tuneForLLDB())` to override the target default? If someone were to debug with a hypothetical GDB port for SCE targets, for example?
> We can still do that by using the `-debug-entry-values` option?
The tuning decision is made in TargetOptionsImpl, which is unusual but that's where the tuning option is actually kept, so I think it's okay.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83462/new/

https://reviews.llvm.org/D83462