[PATCH] D84391: [AMDGPU] Fix incorrect arch assert while setting up FlatScratchInit

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D84391#2169473 <https://reviews.llvm.org/D84391#2169473>, @madhur13490 wrote:

>




> I am not sure what does that mean. Do you agree with my way of refactoring or you're suggesting something else? With my approach there won't be any checks as I said we can get rid of `flatScratchIsPointer()` too.

I mean exactly the opposite. We should not check the generation anywhere. The hardware does not make changes in a nice, disciplined, sequenced way. Everything should be based on specific feature checks. I.e. there should only be flatScratchIsPointer checks, and nothing checking getGeneration


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84391/new/

https://reviews.llvm.org/D84391