[PATCH] D84414: [RISCV] Support Shadow Call Stack

Thu Jul 23 08:01:18 PDT 2020

jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.

================
Comment at: llvm/test/CodeGen/RISCV/shadowcallstack.ll:1-3
+; RUN: llc -verify-machineinstrs -o - %s -mtriple=riscv32-linux-gnu -mattr=+reserve-x18 | FileCheck --check-prefix=RISCV32 %s
+
+; RUN: llc -verify-machineinstrs -o - %s -mtriple=riscv64-linux-gnu -mattr=+reserve-x18 | FileCheck --check-prefix=RISCV64 %s
----------------
Please style these in the same way as the other RISC-V CodeGen tests, in terms of argument order, redirecting stdin rather than using `-o - %s`, and using riscv64 rather than riscv64-linux-gnu (unless needed?). Also use update_llc_test_checks.py rather than hand-writing this. And we generally use RV32I and RV64I (or other appropriate arch strings) instead of RISCV32 and RISCV64 prefixes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84414/new/

https://reviews.llvm.org/D84414