[PATCH] D84349: [llvm][NFC] Remove definition from build system of LLVM_HAVE_TF_AOT

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 07:55:51 PDT 2020


mtrofin added a comment.

In D84349#2168861 <https://reviews.llvm.org/D84349#2168861>, @sanwou01 wrote:

> Are you sure you can include config.h in an installed header file? AFAICT, config.h isn't installed, but llvm-config.h is.
>
> edit: this breaks the build of a certain downstream front-end for me


Ah, I see:

  install(DIRECTORY ${LLVM_INCLUDE_DIR}/llvm ${LLVM_INCLUDE_DIR}/llvm-c
      DESTINATION include
      COMPONENT llvm-headers
      FILES_MATCHING
      PATTERN "*.def"
      PATTERN "*.h"
      PATTERN "*.gen"
      PATTERN "*.inc"
      # Exclude include/llvm/CMakeFiles/intrinsics_gen.dir, matched by "*.def"
      PATTERN "CMakeFiles" EXCLUDE
      PATTERN "config.h" EXCLUDE
      PATTERN ".svn" EXCLUDE
      )

huh. How does include/llvm/Support/Windows/WindowsSupport.h include llvm/Config/config.h though... weird. In any case, I'll move the _AOT definition to llvm_config.h.cmake. Sorry for the trouble!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84349/new/

https://reviews.llvm.org/D84349





More information about the llvm-commits mailing list