[PATCH] D83754: [Attributor] Unittest for Attributor

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 07:51:20 PDT 2020


jdoerfert added inline comments.


================
Comment at: llvm/unittests/Transforms/IPO/AttributorTest.cpp:49
+      A.getOrCreateAAFor<AAIsDead>(IRPosition::function(*F)));
+
+  EXPECT_TRUE(AA);
----------------
This slipped through. @bbn, please don't use this kind of type punning at all. if you need to remove a `const`, there is `const_cast`. I somehow doubt you need to remove the const at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83754/new/

https://reviews.llvm.org/D83754





More information about the llvm-commits mailing list