[PATCH] D84408: [llvm-readobj] - Don't stop dumping when the name of a relocation section can't be read.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:6135-6141
+    StringRef Name = "<?>";
+    if (Expected<StringRef> NameOrErr = Obj->getSectionName(&Sec))
+      Name = *NameOrErr;
+    else
+      this->reportUniqueWarning(createError("unable to get the name of " +
+                                            describe(Obj, Sec) + ": " +
+                                            toString(NameOrErr.takeError())));
----------------
This code looks like something that could be shared both with the GNU style and possibly even more widely with other places getting section names.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84408/new/

https://reviews.llvm.org/D84408