[PATCH] D84330: [llvm-readelf] - Simplify the implementation of getSectionTypeString() helper. NFCI.

Thu Jul 23 02:59:01 PDT 2020

grimar marked an inline comment as done.
grimar added inline comments.

================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:3784-3787
+  // The SHT_ANDROID_RELR is special, all other SHT_ANDROID_* types are handled
+  // in the common block below.
+  if (Name == "SHT_ANDROID_RELR")
     return "RELR";
----------------
jhenderson wrote:
> FWIW, I think this clause is a bad design in the original version - a user when dumping the section headers will not be able to distinguish between SHT_RELR and SHT_ANDROID_RELR. They might be identical internally, but the sh_type value is different.
> 
> We shouldn't fix it in this patch, but it might be worth reaching out to the original people to implement it to bring this up. What do you think?
Yeah. The fresh GNU source code (2.34) still doesn't know about SHT_ANDROID_RELR/SHT_RELR,
so seems it should not be a problem to fix it on LLVM side. I`ll prepare a patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84330/new/

https://reviews.llvm.org/D84330