[PATCH] D84374: [Matrix] Add asserts for mismatched element types.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 02:10:14 PDT 2020


fhahn accepted this revision.
fhahn added a subscriber: SjoerdMeijer.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!

I *think* thanks to @SjoerdMeijer 's recent improvements to the IR verifier, some of those cases should be caught directly by the verifier. But those assertions are helpful in any case, to explicitly state the assumption in the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84374/new/

https://reviews.llvm.org/D84374





More information about the llvm-commits mailing list