[PATCH] D84206: [llvm-libtool-darwin] Add support for -filelist option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 23 00:33:25 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with nit, thanks!



================
Comment at: llvm/test/tools/llvm-libtool-darwin/filelist.test:95
+
+# EMPTY-FILENAME: filename cannot be empty
+
----------------
Let's check the full error line. Presumably, this at least has `error: file list file:` or something similar before it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84206/new/

https://reviews.llvm.org/D84206





More information about the llvm-commits mailing list