[PATCH] D84135: [NFC][IR] add comments and a unit test for User::replaceUsesOfWith

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

In D84135#2162478 <https://reviews.llvm.org/D84135#2162478>, @MaskRay wrote:

> For NFC changes please tag so (you can find plenty of examples in the history). Please upload the full diff (`arc diff` or `git diff 'HEAD^' -U9999`).
>
>  -----
>
> When you commit, please drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script:
>
>   arcfilter () {
>           arc amend
>           git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
>   }
>   
>
> `Reviewed By: ` is considered important by some people. Please keep the tag. (`--date=now` is my personal preference (author dates are usually not useful. Using committer dates can make log almost monotonic in time))
>
> `llvm/utils/git/pre-push.py` can validate the message does not include unneeded tags.


Hi， thank you! I am a newbie here. And I don't know much rule here. Thanks for reminding me this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84135/new/

https://reviews.llvm.org/D84135