[PATCH] D84076: [llvm-exegesis] Unset HAVE_LIBPFM if the kernel is too old.

Wed Jul 22 20:19:15 PDT 2020

oontvoo added a comment.

In D84076#2160082 <https://reviews.llvm.org/D84076#2160082>, @lebedev.ri wrote:

> In D84076#2159963 <https://reviews.llvm.org/D84076#2159963>, @mgorny wrote:
>
> > You shouldn't be checking the running kernel but the version of the kernel headers. Think of build hosts building LLVM for an entirely different system altogether.
>
>
> To add to that, you shouldn't hardcode version, but instead check that the problematic field is present or not.
>  And, i'm not sure this is a good idea. If the kernel is too old, i'd suggest only disabling the functionality
>  that wants that new field, not the entire libpfm

Good point! I've updated the cmake file to look for the field and set a new flag accordingly
Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84076/new/

https://reviews.llvm.org/D84076