[PATCH] D83427: [MSAN] Update tests due to widespread eager checking

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 13:26:44 PDT 2020


eugenis added inline comments.


================
Comment at: compiler-rt/test/msan/signal_stress_test.cpp:7
 // XFAIL: netbsd
+// XFAIL: msan_eager_checks
 
----------------
I think REQUIRES: makes more sense here.


================
Comment at: compiler-rt/test/msan/vararg.cpp:89
       return sum(7,
         a, a, a, a, a, a, uninit
       );
----------------
This test becomes super confusing, I no longer understand all the combinations.
Why do you need explicit __msan_unpoison_param?
It would help to rename EXPECT_PASS and EXPECT_FAIL to reflect what they do (pass uninit or not) instead of what they expect to happen.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83427/new/

https://reviews.llvm.org/D83427





More information about the llvm-commits mailing list