[PATCH] D84353: [flang][openmp] Required clauses are allowed

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 13:19:14 PDT 2020


clementval added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:425
     VersionedClause<OMPC_NoWait>
   ];
 }
----------------
kiranchandramohan wrote:
> Is requiredClause missing here?
Well it is not mandatory but looks like that `map` is required for `target enter data` so it should be moved from `allowedClauses` to `requiredClauses`.  I will update the patch to include this change as well. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84353/new/

https://reviews.llvm.org/D84353





More information about the llvm-commits mailing list