[PATCH] D84233: [lit] Escape ANSI control character in xunit output

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 12:21:27 PDT 2020


yln added inline comments.


================
Comment at: llvm/utils/lit/lit/reports.py:128
             if isinstance(output, bytes):
                 output.decode("utf-8", 'ignore')
+
----------------
I just spotted a bug in this existing code, `decode()` returns a new string.  It should be:
```
output = output.decode('utf-8', 'ignore')
```

Can you check if this would resolve your issue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84233/new/

https://reviews.llvm.org/D84233





More information about the llvm-commits mailing list