[PATCH] D84292: Only enable -Wsuggest-override if it doesn't suggest adding override to functions that are already final

[Erich Keane via Phabricator via llvm-commits]

erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

Fix the comment as I mentioned, otherwise this LGTM.



================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:677
+  # suggest adding 'override' to functions that are already marked 'final' 
+  # (which means it it is disabled for GCC < 9).
+  check_cxx_compiler_flag("-Wsuggest-override" CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG)
----------------
This comment isn't exactly right, the differentation is GCC 9.1 vs GCC9.2.  So it should likely be (which means it is disabled for GCC < 9.2).

ADDITIONALLY, you have the word 'it' twice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84292/new/

https://reviews.llvm.org/D84292