[PATCH] D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm marked an inline comment as done.
cebowleratibm added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:25
+
+; CHECK-DAG:   lfs 1,
+; CHECK-DAG:   lfs 2,
----------------
Xiangling_L wrote:
> cebowleratibm wrote:
> > Note this is lfs and not lfd.  llc appears to be smart enough to use a 4 byte lfs to populate the register when possible.
> I guess it's because `llc` is not default to `-O0`, if you add `-O0`, you will get `lfd` back. And that leads me to think that you may want to add optimization level `-O0` since you aimed at testing `optnone` scenario. Also you can test other optimization level if you are confident that the compiler is doing the right thing.
The original intent of optnone was to make it easier to CHECK-NEXT against the expected register read/writes  around the bl/blr.  Instead I adapted the test in a way to run at opt.  The intention of the test isn't to validate lfs/lfd between opt/noopt.  I don't think the -O0 run is needed.  If this test is run at -O0 it will fail, however, I think that's true of many LLVM tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84069/new/

https://reviews.llvm.org/D84069