[PATCH] D83560: [DebugInfo] Added support for DW_OP_implicit_value in llvm

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:231
+    for (int i = 0; i < NumBytes; ++i)
+      emitData1(Data[i]);
+  }
----------------
`return;`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:233
+  }
+  if (NumBytes == 10 /*long double*/) {
+    // long double IEEE representation uses 80 bits(10 bytes).
----------------
Why would we special-case Float80 instead of just emitting everything that we didn't emit in the above block here unconditionally?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp:245
+  }
+}
+
----------------
should we emit an invalid opcode / and assembler comment / ...  to indicate that there was an error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83560/new/

https://reviews.llvm.org/D83560