[PATCH] D83560: [DebugInfo] Added support for DW_OP_implicit_value in llvm

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 279793.
SouraVX added a comment.

Addressed review comments by @aprantl, Thanks for this.
Changes:

- Edited the summary to reflect the intention.
- This patch switches to `DW_OP_implicit_value` for all the floating point

constants `float`, `double` and `long double`, for demonstration purposes, considering
1 byte space saving(discussed above).

- Changes are still a bit conservative, in a sense emission

of `DW_OP_implicit_value` is guarded with additional check for debugger tunning.
This will ensure that, we didn't break any existing machinery/consumers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83560/new/

https://reviews.llvm.org/D83560

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
  llvm/test/DebugInfo/X86/implicit_value-double.ll
  llvm/test/DebugInfo/X86/implicit_value-float.ll
  llvm/test/DebugInfo/X86/implicit_value-ld.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83560.279793.patch
Type: text/x-patch
Size: 12477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200722/5c0cc63e/attachment.bin>