[PATCH] D83056: Separate the Loop Peeling Utilities from the Loop Unrolling Utilities

Wed Jul 22 05:58:00 PDT 2020

fhahn added a comment.

In D83056#2162928 <https://reviews.llvm.org/D83056#2162928>, @Meinersbur wrote:

> @fhahn Any remaining concerns? I would accept the patch if not.

I think everything besides the remaining question about the include changes has been addressed.

================
Comment at: llvm/lib/Transforms/Utils/LoopPeel.cpp:28
-#include "llvm/IR/InstrTypes.h"
-#include "llvm/IR/Instruction.h"
-#include "llvm/IR/Instructions.h"
----------------
I am still not sure why those includes were removed? If they are not needed independently of this change, it should be a separate patch. Usually we include what is used in each .cpp file. Things might build because some headers are included by other headers in turn, but usually we do not rely on that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83056/new/

https://reviews.llvm.org/D83056