[PATCH] D84309: [InstCombine] Preserve FMA opportunities when combining PHI nodes

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 05:09:33 PDT 2020


spatel added a reviewer: lebedev.ri.
spatel added a comment.

Avoiding the canonicalization seems unlikely to be a universal win and won't solve the problem if the source was already in the form that we want to avoid.
I think we need to reverse the transform in CodeGenPrepare. There we can use TTI/TLI to decide if it is profitable (at the least, the target should have custom/legal FMA lowering for the value type in question?).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84309/new/

https://reviews.llvm.org/D84309





More information about the llvm-commits mailing list