[PATCH] D84209: [llvm-libtool-darwin] Add support for -D option

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D84209#2164501 <https://reviews.llvm.org/D84209#2164501>, @sameerarora101 wrote:

> In D84209#2163675 <https://reviews.llvm.org/D84209#2163675>, @jhenderson wrote:
>
> > Documentation for this option? Also, you've changed the default behaviour of the tool from being deterministic to being non-deterministic. Are you sure that's what you want?
>
>
> Would changing the default behavior to being non-deterministic be a problem? This, non-deterministic behavior, is the default behavior of cctools' libtool and so I thought of replicating that here.
>  I have added the docs now, thanks!


I don't know whether it would be a problem or not, but it does make comparing archives harder. That being said, in our downstream llvm-ar, we've had to override the default to use non-deterministic timestamps, because our build system relies on the timestamps being accurate, so that might be evidence that changing it is good. I don't know if it's important to people outside our environment though - there aren't lots of people complaining about the current upstream llvm-ar behaviour, so matching that might make more sense. I don't really have an opinion either way. I'm happy for users of the tool to provide guidance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84209/new/

https://reviews.llvm.org/D84209