[PATCH] D84294: [SCEV] Remove invalid assert. PR46786

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 22 01:29:50 PDT 2020


mkazantsev added a comment.

I think we have some cases (related to mul) where "is pointer" notion can be lost. Maybe we can fix it. Let me try to construct some more examples of those.

Generally, the assert looks like we might have it, but first we should be certain that we ensure it is actually so. It might take some extensive work (I see some checks like "we do not work with pointer this or that" over the code).

Let me try to find more tests that fail this assert with educated guesses. Then I'll add them here, and then, when all of them are resolved, I'm fine with returning assert.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84294/new/

https://reviews.llvm.org/D84294





More information about the llvm-commits mailing list