[PATCH] D84238: [PowerPC] Set v1i128 to expand for SETCC to avoid crash

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 22:56:14 PDT 2020


steven.zhang added a comment.

I still think there is something missing here. What you set the legalize action for SETCC is under P8 <https://reviews.llvm.org/P8> altivec, but why the case passed for P7 <https://reviews.llvm.org/P7> ? And this case passed without your patch :

  define <1 x i1> @setcc_v1i128(<1 x i128> %a) {
  entry:
    %0 = icmp ult <1 x i128> %a, <i128 35708>
    ret <1 x i1> %0
  }

The only difference I see is that, it is `v1i1 = setcc t47, t74, setult:ch` instead of `v1i128 = setcc t47, t74, setult:ch`. So, what happens here ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84238/new/

https://reviews.llvm.org/D84238





More information about the llvm-commits mailing list