[PATCH] D84195: [flang][openacc] Skeleton for OpenACC construct lowering

[Valentin Clement via Phabricator via llvm-commits]

clementval marked 2 inline comments as done.
clementval added inline comments.


================
Comment at: flang/include/flang/Lower/PFTBuilder.h:135
+    std::tuple<parser::CompilerDirective, parser::OpenACCConstruct,
+               parser::OpenMPConstruct, parser::OmpEndLoopDirective>;
 
----------------
ichoyjx wrote:
> We may need `EndLoopDirective` for OpenACC also because for combined constructs, the `end * loop` is optional.
Right we might add a `OpenACCEndCombinedDirective`. Since it is not in the current parser, do you mind if we had this in a follow up patch together with the parsing part and some parsing tests?


================
Comment at: flang/test/Lower/pre-fir-tree05.f90:29
+  ! CHECK-NEXT: <<End OpenACCConstruct>>
+  ! CHECK-NEXT: <<End OpenACCConstruct>>
+  ! CHECK-NEXT: ContinueStmt
----------------
ichoyjx wrote:
> What is the second `<<End OpenACCConstruct>>` here?
That's the end of the loop block. Similar to `pre-fir-tree03.f90` this is output for the `!$omp do` on line 32 check at line 41.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84195/new/

https://reviews.llvm.org/D84195