[PATCH] D82084: [DebugInfo] Refactored out `debug_line.dwo` emission from `DwarfTypeUnit` to `DwarfDebug`

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 16:45:19 PDT 2020


dblaikie added a comment.

In D82084#2160122 <https://reviews.llvm.org/D82084#2160122>, @SouraVX wrote:

> Tried one more time disregarding both the approach followed previously.
>  This time finally worked out(in a much cleaner way).
>  It exposes `getDwoLineTable` private method. But IMO that's needed
>  anyways, since it will used/needed subsequently in D81476 <https://reviews.llvm.org/D81476>.
>
> @dblaikie, Could you please share your thoughts on this.
>  I hope this should avoid the rework from your side.
>
> Thanks!


I've posted this as a possible alternative solution/direction - seems simple enough to me, but perhaps I'm missing some cases/understanding? D84278 <https://reviews.llvm.org/D84278>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82084/new/

https://reviews.llvm.org/D82084





More information about the llvm-commits mailing list