[PATCH] D84069: [NFC][PPC][AIX] Add test coverage for _Complex return values

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm marked 2 inline comments as done.
cebowleratibm added a comment.

added some commentary notes for the review.



================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:25
+
+; CHECK-DAG:   lfs 1,
+; CHECK-DAG:   lfs 2,
----------------
Note this is lfs and not lfd.  llc appears to be smart enough to use a 4 byte lfs to populate the register when possible.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-complex.ll:91
+  %retval.imagp = getelementptr inbounds { ppc_fp128, ppc_fp128 }, { ppc_fp128, ppc_fp128 }* %retval, i32 0, i32 1
+  store ppc_fp128 0xM7ffeffffffffffffffffffffffffffff, ppc_fp128* %retval.realp, align 16
+  store ppc_fp128 0xM3ffefffffffffffffffffffffffffffe, ppc_fp128* %retval.imagp, align 16
----------------
The bit patterns were chosen deliberately to avoid redundancy otherwise llc will initialize the call registers with reg copies rather than lfd.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84069/new/

https://reviews.llvm.org/D84069