[PATCH] D84165: GlobalISel: Look through G_ANYEXT and G_IMPLICIT_DEF for constants

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 14:28:57 PDT 2020


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/Utils.cpp:289
     case TargetOpcode::G_ZEXT:
+    case TargetOpcode::G_ANYEXT:
       SeenOpcodes.push_back(std::make_pair(
----------------
paquette wrote:
> Is there any reason we weren't doing this before?
I don't know. I guess it's slightly weird to just treat these as 0 and not something distinct.

Another oddity is when rolling back the seen casts at the end, no extend is applied. This is also the case for G_INTTOPTR (although I think this case is actually broken)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84165/new/

https://reviews.llvm.org/D84165





More information about the llvm-commits mailing list