[PATCH] D75980: [LV] Generate RT checks up-front and remove them if required. (WIP)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 12:22:28 PDT 2020


fhahn added a comment.

In D75980#2164971 <https://reviews.llvm.org/D75980#2164971>, @lebedev.ri wrote:

> Reverse-ping. Can i somehow help get this going? :)


I actually started rebasing/updating over the weekend. There are a few more loose ends to tie up, but I should be able to share an update in the next few days.

>> One potential drawback of this patch is that we speculatively
>>  generate IR which we might have to clean up later. However it seems like
>>  the code required to do so is quite manageable.
> 
> There's prior art for that, loop idiom pass has `ExpandedValuesCleaner` e.g.

Yes, part of the update is to fix SCEVExpander to actually collect all instructions it generates automatically, so they can be cleaned up later. It already does so for some instructions, but is missing a ton of cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75980/new/

https://reviews.llvm.org/D75980





More information about the llvm-commits mailing list