[PATCH] D72904: [ELF] Allow SHF_LINK_ORDER sections to have sh_link=0

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 11:33:28 PDT 2020


MaskRay added a comment.

See also @jhenderson's latest reply to the generic-abi thread "SHF_LINK_ORDER's original semantics make upgrade difficult" <https://groups.google.com/forum/#!topic/generic-abi/hgx_m1aXqUo>

  # input.o:
  <table header> [common]
  - DW_TAG_compile_unit [common]
  -- DW_TAG_variable [.data.foo]
  -- DW_TAG_namespace [common]
  --- DW_TAG_subprogram [.text.bar]
  --- DW_TAG_variable [.data.baz]
  <table footer> [common]

@pcc I sent the patches since you expressed a preference on more work on SHF_LINK_ORDER. Though, @jhenderson's needs (and my header/footer argument in that thread) make me think more whether we should continue patching SHF_LINK_ORDER or start pursuing another section flag.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72904/new/

https://reviews.llvm.org/D72904





More information about the llvm-commits mailing list